Error codes more specifics

This is not for security or privacy reasons, but to provide an accurate answer to a search request.

src/route/hkp.js

@@ -136,7 +136,9 @@ class HKP {
       ctx.body = `info:${VERSION}:${COUNT}\npub:${fp}:${algo}:${key.keySize}:${created}::\n`;
 
       for (const uid of key.userIds) {
-        ctx.body += `uid:${encodeURIComponent(`${uid.name} <${uid.email}>`)}:::\n`;
+        if(uid.verified) {
+          ctx.body += `uid:${encodeURIComponent(`${uid.name} <${uid.email}>`)}:::\n`;
+        }
       }
     }
   }

src/service/pgp.js

@@ -48,7 +48,7 @@ class PGP {
       log.error('pgp', 'Failed to parse PGP key:\n%s', publicKeyArmored, error);
       util.throw(500, 'Failed to parse PGP key');
     } else if (!r.keys || r.keys.length !== 1 || !r.keys[0].primaryKey) {
-      util.throw(400, 'Invalid PGP key: only one key can be uploaded');
+      util.throw(501, 'Invalid PGP key: only one key can be uploaded');
     }
 
     // verify primary key
@@ -64,14 +64,14 @@ class PGP {
     const keyId = primaryKey.getKeyId().toHex();
     const fingerprint = primaryKey.getFingerprint();
     if (!util.isKeyId(keyId) || !util.isFingerPrint(fingerprint)) {
-      util.throw(400, 'Invalid PGP key: only v4 keys are accepted');
+      util.throw(501, 'Invalid PGP key: only v4 keys are accepted');
     }
 
     // check for at least one valid user id
     const {userIds, status} = await this.parseUserIds(key.users, primaryKey, verifyDate);
     if (!userIds.length) {
       if (status == 1) {
-        util.throw(400, 'Invalid PGP key: no user ID comes from a valid organisation');
+        util.throw(403, 'Invalid PGP key: no user ID comes from a valid organisation');
       }
       else {
         util.throw(400, 'Invalid PGP key: invalid user IDs');

src/static/js/key-armored.js

@@ -0,0 +1,35 @@
+/* eslint-disable */
+
+;(function($) {
+  'use strict';
+  
+  $('#copy-button').tooltip({
+    trigger: 'manual',
+    placement: 'right',
+  });
+
+  function setTooltip(message) {
+    $('#copy-button').attr('data-original-title', message)
+      .tooltip('show');
+  }
+
+  function hideTooltip() {
+    setTimeout(function() {
+      $('#copy-button').tooltip('hide');
+    }, 1000);
+  }
+
+  $('#copy-button').click(function(e) {
+    const copyText = $('#publickey-block').text();
+    const textArea = document.createElement('textarea');
+    textArea.textContent = copyText;
+    document.body.append(textArea);
+    textArea.select();
+    document.execCommand("copy");
+    textArea.remove();
+    
+    setTooltip('Key copied to clipboard!');
+    hideTooltip();
+  });
+
+}(jQuery));

src/view/key-armored.html

@@ -1,3 +1,13 @@
+<style type="text/css">
+ 
+ textarea {
+    position: absolute;
+    left: -100%;
+  }
+}
+ 
+</style>
+
 <div class="container">
 
   <div class="header clearfix">
@@ -14,10 +24,14 @@
   <div class="row marketing">
     <div class="col-lg-12">
       <h4><%= query.email ? `Email: ${query.email}` : query.fingerprint ? `Fingerprint: ${query.fingerprint}` : `Key ID: ${query.keyId}` %></h4>
-      <pre><%= key.publicKeyArmored %></pre>
+      <button id="copy-button" class="btn btn-primary">Copy key to clipboard</button>
+      <pre id="publickey-block"><%= key.publicKeyArmored %></pre>
     </div> <!-- /col-lg-12 -->
   </div>
 
   <%- include('footer') %>
 
 </div> <!-- /container -->
+<script src="/js/jquery.min.js"></script>
+<script src="/js/bootstrap-3.4.1.min.js"></script>
+<script src="/js/key-armored.js"></script>