From 41b16b7561c392abbeab2a67d715c42ff5d5ff8a Mon Sep 17 00:00:00 2001 From: hotoo Date: Thu, 21 May 2015 08:34:36 +0800 Subject: [PATCH 1/2] optimize use regexp without caught group --- index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.js b/index.js index e6a30fa..4cfb385 100644 --- a/index.js +++ b/index.js @@ -35,7 +35,7 @@ module.exports = function (app, options) { var names = fs.readdirSync(localeDir); for (var i = 0; i < names.length; i++) { var name = names[i]; - if (!/\.(js|json|properties)$/.test(name)) { + if (!/\.(?:js|json|properties)$/.test(name)) { continue; } var filepath = path.join(localeDir, name); From 4ecffe8d22368f4a2cb65113600d9a514b10274e Mon Sep 17 00:00:00 2001 From: hotoo Date: Thu, 21 May 2015 08:39:30 +0800 Subject: [PATCH 2/2] refact: arguments to array. --- index.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/index.js b/index.js index 4cfb385..4e3411e 100644 --- a/index.js +++ b/index.js @@ -109,11 +109,8 @@ module.exports = function (app, options) { } // __(key, value1, value2, value3, value4, value5, ...) - var args = new Array(arguments.length); + var args = Array.prototype.slice.call(arguments); args[0] = text; - for(var i = 1; i < args.length; i++) { - args[i] = arguments[i]; - } return util.format.apply(util, args); };