simonvareille/keyserver
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Migrate email module

Browse Source
This commit is contained in:
Tankred Hase
2017-08-16 12:27:03 +08:00
parent 874903c64b
commit ba671126db
3 changed files with 32 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
test/unit/email-test.js
View File

@@ -5,6 +5,7 @@ const Email = require('../../src/email/email');
const nodemailer = require('nodemailer');
describe('Email Unit Tests', () => {
let sandbox;
let email;
let sendFnStub;
@@ -36,13 +37,14 @@ describe('Email Unit Tests', () => {
};
beforeEach(() => {
sandbox = sinon.sandbox.create();
sendFnStub = sinon.stub();
sinon.stub(nodemailer, 'createTransport').returns({
sandbox.stub(nodemailer, 'createTransport').returns({
templateSender: () => sendFnStub
});
sinon.stub(log, 'warn');
sinon.stub(log, 'error');
sandbox.stub(log);
email = new Email(nodemailer);
email.init({
@@ -54,50 +56,44 @@ describe('Email Unit Tests', () => {
});
afterEach(() => {
nodemailer.createTransport.restore();
log.warn.restore();
log.error.restore();
sandbox.restore();
});
describe("send", () => {
beforeEach(() => {
sinon.stub(email, '_sendHelper').returns(Promise.resolve({response: '250'}));
sandbox.stub(email, '_sendHelper').resolves({response: '250'});
});
afterEach(() => {
email._sendHelper.restore();
});
it('should work', function *() {
const info = yield email.send({template, userId: userId1, keyId, origin});
it('should work', async() => {
const info = await email.send({template, userId: userId1, keyId, origin});
expect(info.response).to.match(/^250/);
});
});
describe("_sendHelper", () => {
it('should work', function *() {
sendFnStub.returns(Promise.resolve({response: '250'}));
it('should work', async() => {
sendFnStub.resolves({response: '250'});
const info = yield email._sendHelper(mailOptions);
const info = await email._sendHelper(mailOptions);
expect(info.response).to.match(/^250/);
});
it('should log warning for reponse error', function *() {
sendFnStub.returns(Promise.resolve({response: '554'}));
it('should log warning for reponse error', async() => {
sendFnStub.resolves({response: '554'});
const info = yield email._sendHelper(mailOptions);
const info = await email._sendHelper(mailOptions);
expect(info.response).to.match(/^554/);
expect(log.warn.calledOnce).to.be.true;
});
it('should fail', function *() {
sendFnStub.returns(Promise.reject(new Error('boom')));
it('should fail', async() => {
sendFnStub.rejects(new Error('boom'));
try {
yield email._sendHelper(mailOptions);
await email._sendHelper(mailOptions);
} catch (e) {
expect(log.error.calledOnce).to.be.true;
expect(e.status).to.equal(500);